Conversation
| @@ -126,8 +126,6 @@ def __init__( | |||
| smagorinski_scaling_factor: float = 0.015, | |||
There was a problem hiding this comment.
wondering if we should cherry-pick the changes in config from the configuration PR #936
|
cscs-ci run default |
|
cscs-ci run distributed |
jcanton
left a comment
jcanton
left a comment
There was a problem hiding this comment.
for a moment I thought you had removed thhgtd_zdiffu and thslp_zdiffu from the entire codebase :-)
LGTM
|
cscs-ci run default |
|
cscs-ci run distributed |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
muellch
left a comment
muellch
left a comment
There was a problem hiding this comment.
I hope you did not wait for my approval,
looks good, can be merged!
3 participants
thslp_zdiffuandthhgtd_zdiffufrom the Fortran bindings as they are not usedcompute_3d_smag_coeffas we don't support this modehdiff_w_efdt_ratioto the Fortran bindings (though for now we don't have any experiment that deviates from the default value)